-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SDK-4393] feat(auth): Support Organization Name with Authorization API #719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evansims
added
Scope: Improvement
Code changes including new features or enhancements to the library.
Roadmap: Next Minor
Targets the next minor release of the library.
labels
Jul 18, 2023
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #719 +/- ##
===========================================
Coverage 100.00% 100.00%
- Complexity 1311 1327 +16
===========================================
Files 62 62
Lines 4587 4613 +26
===========================================
+ Hits 4587 4613 +26
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
stevehobbsdev
requested changes
Jul 18, 2023
Thanks @stevehobbsdev, updated with changes to reflect that conversation. |
stevehobbsdev
approved these changes
Jul 19, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Roadmap: Next Minor
Targets the next minor release of the library.
Scope: Improvement
Code changes including new features or enhancements to the library.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR adds support for authorizing using an organization name. This enhances the existing support for authorizing using an organization ID. Example usage follows:
✨ (New) Authorization using an organization name:
(Existing) support for authorization using an organization ID:
(Updated) The SDK treats the
organization
parameter as an allowlist for applications that need to work with multiple organizations. It now accepts organization names, as well as existing support for IDs.(Existing) When redirecting for authorization, the
organization
allowlist's first value is used by default. This behavior can be overridden using method parameters:References
Please review the internal Jira ticket SDK-4393 for further information.
Testing
composer test
from a clone of the branch to test locally.Contributor Checklist